PMD Results
The following document contains the results of PMD 5.1.2.
Files
TrAP Android Library - com/ericsson/research/trap/utils/AndroidPackageScanner.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 126–128 |
TrAP API - com/ericsson/research/trap/TrapChannel.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 119 |
| Avoid modifiers which are implied by the context | 138 |
| Avoid modifiers which are implied by the context | 145 |
| Avoid modifiers which are implied by the context | 156 |
| Avoid modifiers which are implied by the context | 164 |
| Avoid modifiers which are implied by the context | 178 |
| Avoid modifiers which are implied by the context | 186 |
| Avoid modifiers which are implied by the context | 204 |
| Avoid modifiers which are implied by the context | 211 |
TrAP API - com/ericsson/research/trap/TrapClient.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.ericsson.research.trap.delegates.TrapDelegate' | 38 |
| Avoid modifiers which are implied by the context | 70 |
TrAP API - com/ericsson/research/trap/TrapEndpoint.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.ericsson.research.trap.delegates.TrapDelegate' | 44 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 132 |
| Avoid modifiers which are implied by the context | 148 |
| Avoid modifiers which are implied by the context | 163 |
| Avoid modifiers which are implied by the context | 169 |
| Avoid modifiers which are implied by the context | 175 |
| Avoid modifiers which are implied by the context | 181 |
| Avoid modifiers which are implied by the context | 187 |
| Avoid modifiers which are implied by the context | 193 |
| Avoid modifiers which are implied by the context | 202 |
| Avoid modifiers which are implied by the context | 209 |
| Avoid modifiers which are implied by the context | 219 |
| Avoid modifiers which are implied by the context | 227 |
| Avoid modifiers which are implied by the context | 242 |
| Avoid modifiers which are implied by the context | 249 |
| Avoid modifiers which are implied by the context | 256 |
| Avoid modifiers which are implied by the context | 263 |
| Avoid modifiers which are implied by the context | 290 |
| Avoid modifiers which are implied by the context | 327 |
| Avoid modifiers which are implied by the context | 336 |
| Avoid modifiers which are implied by the context | 348 |
| Avoid modifiers which are implied by the context | 358 |
| Avoid modifiers which are implied by the context | 379 |
| Avoid modifiers which are implied by the context | 389 |
| Avoid modifiers which are implied by the context | 414 |
| Avoid modifiers which are implied by the context | 434 |
| Avoid modifiers which are implied by the context | 448 |
| Avoid modifiers which are implied by the context | 457 |
| Avoid modifiers which are implied by the context | 482 |
| Avoid modifiers which are implied by the context | 492 |
| Avoid modifiers which are implied by the context | 511 |
| Avoid modifiers which are implied by the context | 526 |
| Avoid modifiers which are implied by the context | 539 |
| Avoid modifiers which are implied by the context | 553 |
| Avoid modifiers which are implied by the context | 563 |
| Avoid modifiers which are implied by the context | 576 |
| Avoid modifiers which are implied by the context | 622 |
TrAP API - com/ericsson/research/trap/TrapEndpointDelegate.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 91 |
| Avoid modifiers which are implied by the context | 119 |
TrAP API - com/ericsson/research/trap/TrapListener.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 100 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 130 |
TrAP API - com/ericsson/research/trap/TrapObject.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 67 |
TrAP API - com/ericsson/research/trap/TrapPeer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54–63 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 82 |
TrAP API - com/ericsson/research/trap/TrapSettings.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 96 |
| Avoid modifiers which are implied by the context | 105 |
| Avoid modifiers which are implied by the context | 115 |
| Avoid modifiers which are implied by the context | 136 |
| Avoid modifiers which are implied by the context | 150 |
| Avoid modifiers which are implied by the context | 160 |
| Avoid modifiers which are implied by the context | 169 |
| Avoid modifiers which are implied by the context | 181 |
| Avoid modifiers which are implied by the context | 191 |
| Avoid modifiers which are implied by the context | 212 |
| Avoid modifiers which are implied by the context | 222 |
TrAP API - com/ericsson/research/trap/auth/TrapAuthentication.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 101 |
| Avoid modifiers which are implied by the context | 126 |
| Avoid modifiers which are implied by the context | 138 |
| Avoid modifiers which are implied by the context | 158 |
TrAP API - com/ericsson/research/trap/delegates/OnAccept.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.ericsson.research.trap.TrapState' | 40 |
| Avoid modifiers which are implied by the context | 73 |
TrAP API - com/ericsson/research/trap/delegates/OnClose.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 60 |
TrAP API - com/ericsson/research/trap/delegates/OnData.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 77 |
TrAP API - com/ericsson/research/trap/delegates/OnError.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 60 |
TrAP API - com/ericsson/research/trap/delegates/OnFailedSending.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 73 |
TrAP API - com/ericsson/research/trap/delegates/OnObject.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 77 |
TrAP API - com/ericsson/research/trap/delegates/OnOpen.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 59 |
TrAP API - com/ericsson/research/trap/delegates/OnSleep.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.ericsson.research.trap.TrapState' | 39 |
| Avoid modifiers which are implied by the context | 60 |
TrAP API - com/ericsson/research/trap/delegates/OnStateChange.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 65 |
TrAP API - com/ericsson/research/trap/delegates/OnWakeup.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 59 |
TrAP API - com/ericsson/research/trap/examples/ConfiguredServer.java
| Violation | Line |
|---|---|
| Do not hard code the IP address | 110 |
| Do not hard code the IP address | 119 |
TrAP API - com/ericsson/research/trap/spi/ListenerTrapTransport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 75 |
TrAP API - com/ericsson/research/trap/spi/ListenerTrapTransportDelegate.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 61 |
TrAP API - com/ericsson/research/trap/spi/TrapHostingTransport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 61–115 |
| Avoid modifiers which are implied by the context | 134 |
| Avoid modifiers which are implied by the context | 140 |
TrAP API - com/ericsson/research/trap/spi/TrapKeepaliveDelegate.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 85 |
TrAP API - com/ericsson/research/trap/spi/TrapKeepalivePredictor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 168 |
| Avoid modifiers which are implied by the context | 175 |
TrAP API - com/ericsson/research/trap/spi/TrapMessage.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 82–315 |
| Avoid modifiers which are implied by the context | 327–355 |
| Avoid modifiers which are implied by the context | 365 |
| Avoid modifiers which are implied by the context | 380 |
| Avoid modifiers which are implied by the context | 388 |
| Avoid modifiers which are implied by the context | 397 |
| Avoid modifiers which are implied by the context | 404 |
| Avoid modifiers which are implied by the context | 413 |
| Avoid modifiers which are implied by the context | 420 |
| Avoid modifiers which are implied by the context | 429 |
| Avoid modifiers which are implied by the context | 436 |
| Avoid modifiers which are implied by the context | 445 |
| Avoid modifiers which are implied by the context | 455 |
| Avoid modifiers which are implied by the context | 462 |
| Avoid modifiers which are implied by the context | 472 |
| Avoid modifiers which are implied by the context | 483 |
| Avoid modifiers which are implied by the context | 491 |
| Avoid modifiers which are implied by the context | 510 |
| Avoid modifiers which are implied by the context | 518 |
| Avoid modifiers which are implied by the context | 542 |
TrAP API - com/ericsson/research/trap/spi/TrapMessageBuffer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 76 |
TrAP API - com/ericsson/research/trap/spi/TrapTransport.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.ericsson.research.trap.TrapKeepalivePolicy' | 42 |
| Avoid unused imports such as 'com.ericsson.research.trap.utils.SSLUtil.SSLMaterial' | 47 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 92 |
| Avoid modifiers which are implied by the context | 98 |
| Avoid modifiers which are implied by the context | 103 |
| Avoid modifiers which are implied by the context | 109 |
| Avoid modifiers which are implied by the context | 114 |
| Avoid modifiers which are implied by the context | 119 |
| Avoid modifiers which are implied by the context | 126 |
| Avoid modifiers which are implied by the context | 131 |
| Avoid modifiers which are implied by the context | 138 |
| Avoid modifiers which are implied by the context | 144 |
| Avoid modifiers which are implied by the context | 150 |
| Avoid modifiers which are implied by the context | 159 |
| Avoid modifiers which are implied by the context | 172 |
| Avoid modifiers which are implied by the context | 180 |
| Avoid modifiers which are implied by the context | 188 |
| Avoid modifiers which are implied by the context | 197 |
| Avoid modifiers which are implied by the context | 205 |
| Avoid modifiers which are implied by the context | 217 |
| Avoid modifiers which are implied by the context | 229 |
| Avoid modifiers which are implied by the context | 237 |
| Avoid modifiers which are implied by the context | 244 |
| Avoid modifiers which are implied by the context | 255 |
| Avoid modifiers which are implied by the context | 267 |
| Avoid modifiers which are implied by the context | 274 |
| Avoid modifiers which are implied by the context | 281 |
| Avoid modifiers which are implied by the context | 298 |
| Avoid modifiers which are implied by the context | 306 |
| Avoid modifiers which are implied by the context | 313 |
| Avoid modifiers which are implied by the context | 321 |
| Avoid modifiers which are implied by the context | 348 |
| Avoid modifiers which are implied by the context | 355 |
| Avoid modifiers which are implied by the context | 363 |
| Avoid modifiers which are implied by the context | 382 |
| Avoid modifiers which are implied by the context | 389 |
| Avoid modifiers which are implied by the context | 399 |
| Avoid modifiers which are implied by the context | 408 |
| Avoid modifiers which are implied by the context | 426 |
| Avoid modifiers which are implied by the context | 432 |
| Avoid modifiers which are implied by the context | 441 |
| Avoid modifiers which are implied by the context | 448 |
| Avoid modifiers which are implied by the context | 459 |
| Avoid modifiers which are implied by the context | 467 |
| Avoid modifiers which are implied by the context | 472 |
| Avoid modifiers which are implied by the context | 477 |
| Avoid modifiers which are implied by the context | 485 |
| Avoid modifiers which are implied by the context | 494 |
| Avoid modifiers which are implied by the context | 503 |
| Avoid modifiers which are implied by the context | 513 |
TrAP API - com/ericsson/research/trap/spi/TrapTransportDelegate.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 84 |
| Avoid modifiers which are implied by the context | 97 |
| Avoid modifiers which are implied by the context | 105 |
TrAP API - com/ericsson/research/trap/spi/TrapTransportState.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 89–92 |
TrAP API - com/ericsson/research/trap/spi/TrapWakeupMethod.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 55 |
TrAP API - com/ericsson/research/trap/spi/TrapWakeupMethodDelegate.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
TrAP API - com/ericsson/research/trap/spi/queues/BlockingMessageQueue.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 56 |
TrAP API - com/ericsson/research/trap/spi/queues/MessageQueue.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 103 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 124 |
| Avoid modifiers which are implied by the context | 131 |
| Avoid modifiers which are implied by the context | 140 |
| Avoid modifiers which are implied by the context | 147 |
| Avoid modifiers which are implied by the context | 155 |
TrAP API - com/ericsson/research/trap/spi/queues/ResizableMessageQueue.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 55 |
TrAP Core - com/ericsson/research/trap/impl/ClientTrapEndpoint.java
| Violation | Line |
|---|---|
| Useless parentheses. | 85 |
| Useless parentheses. | 236 |
| Useless parentheses. | 236 |
| Useless parentheses. | 236 |
| Useless parentheses. | 240 |
| Useless parentheses. | 240 |
| Useless parentheses. | 280 |
| Useless parentheses. | 280 |
| Useless parentheses. | 280 |
| Useless parentheses. | 369 |
| Useless parentheses. | 369 |
| These nested if statements could be combined | 371–372 |
| Useless parentheses. | 536 |
| Useless parentheses. | 536 |
| Useless parentheses. | 536 |
| Avoid empty catch blocks | 595–598 |
| Avoid returning from a finally block | 625 |
| Useless parentheses. | 657 |
| Useless parentheses. | 661 |
| Overriding method merely calls super | 692–695 |
| These nested if statements could be combined | 704–719 |
| Useless parentheses. | 704 |
| Useless parentheses. | 704 |
| Useless parentheses. | 811 |
| Useless parentheses. | 811 |
| Useless parentheses. | 811 |
TrAP Core - com/ericsson/research/trap/impl/ListenerTrapEndpoint.java
| Violation | Line |
|---|---|
| Useless parentheses. | 104 |
| Useless parentheses. | 104 |
| Avoid empty catch blocks | 116–118 |
| Avoid empty catch blocks | 146–148 |
| Avoid empty catch blocks | 342–344 |
TrAP Core - com/ericsson/research/trap/impl/ServerTrapEndpoint.java
| Violation | Line |
|---|---|
| Useless parentheses. | 181 |
| Useless parentheses. | 181 |
| Useless parentheses. | 184 |
| Useless parentheses. | 184 |
| Avoid empty if statements | 185–187 |
| Useless parentheses. | 199 |
TrAP Core - com/ericsson/research/trap/impl/TrapChannelImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 328 |
| Useless parentheses. | 328 |
| Useless parentheses. | 334 |
| Useless parentheses. | 334 |
| Useless parentheses. | 358 |
| Avoid empty finally blocks | 441–443 |
| Avoid empty finally blocks | 573–576 |
TrAP Core - com/ericsson/research/trap/impl/TrapEndpointImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 209–211 |
| Avoid empty catch blocks | 237–239 |
| Useless parentheses. | 392 |
| Useless parentheses. | 392 |
| Useless parentheses. | 465 |
| Useless parentheses. | 465 |
| Useless parentheses. | 468 |
| Avoid empty catch blocks | 481–484 |
| Avoid empty catch blocks | 487–489 |
| Useless parentheses. | 585 |
| Avoid empty if statements | 633–635 |
| Avoid empty catch blocks | 668–670 |
| Useless parentheses. | 676 |
| Useless parentheses. | 676 |
| Useless parentheses. | 709 |
| Useless parentheses. | 744 |
| Useless parentheses. | 744 |
| Useless parentheses. | 747 |
| These nested if statements could be combined | 747–765 |
| Useless parentheses. | 747 |
| These nested if statements could be combined | 751–764 |
| Useless parentheses. | 758 |
| Useless parentheses. | 758 |
| Useless parentheses. | 1103 |
| Useless parentheses. | 1335 |
| Useless parentheses. | 1335 |
| Useless parentheses. | 1611 |
| Useless parentheses. | 1611 |
| Useless parentheses. | 1671 |
| Useless parentheses. | 1671 |
| These nested if statements could be combined | 1689–1690 |
| Useless parentheses. | 1802 |
| Useless parentheses. | 1802 |
| Useless parentheses. | 1802 |
| Useless parentheses. | 1805 |
| Useless parentheses. | 1805 |
| Useless parentheses. | 1809 |
| Useless parentheses. | 1866 |
| Useless parentheses. | 1866 |
TrAP Core - com/ericsson/research/trap/impl/TrapImplDebugPrinter.java
| Violation | Line |
|---|---|
| Ensure you override both equals() and hashCode() | 165 |
TrAP Core - com/ericsson/research/trap/impl/TrapMessageImpl.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'signed'. | 192 |
| Useless parentheses. | 332 |
| Useless parentheses. | 372 |
| Useless parentheses. | 372 |
TrAP Core - com/ericsson/research/trap/impl/TrapPeerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 247 |
| Useless parentheses. | 251 |
| These nested if statements could be combined | 397–403 |
| These nested if statements could be combined | 399–402 |
| Avoid empty catch blocks | 425–427 |
| Useless parentheses. | 445 |
| Useless parentheses. | 445 |
| Useless parentheses. | 445 |
| Useless parentheses. | 452 |
| Useless parentheses. | 452 |
| Useless parentheses. | 489 |
| Useless parentheses. | 489 |
| Useless parentheses. | 489 |
| Useless parentheses. | 540 |
| Useless parentheses. | 540 |
| These nested if statements could be combined | 542–546 |
| Avoid empty catch blocks | 581–583 |
TrAP Core - com/ericsson/research/trap/impl/queues/ArrayBlockingMessageQueue.java
| Violation | Line |
|---|---|
| Useless parentheses. | 124 |
TrAP Core - com/ericsson/research/trap/impl/queues/LinkedBlockingMessageQueue.java
| Violation | Line |
|---|---|
| Useless parentheses. | 98 |
| Useless parentheses. | 98 |
TrAP Core - com/ericsson/research/trap/impl/queues/LinkedByteBlockingMessageQueue.java
| Violation | Line |
|---|---|
| Useless parentheses. | 102 |
| Useless parentheses. | 102 |
| Useless parentheses. | 136 |
| Avoid empty catch blocks | 140–142 |
TrAP Core - com/ericsson/research/trap/impl/queues/LinkedByteMessageQueue.java
| Violation | Line |
|---|---|
| Useless parentheses. | 67 |
| Useless parentheses. | 67 |
TrAP Core - com/ericsson/research/trap/impl/queues/LinkedMessageQueue.java
| Violation | Line |
|---|---|
| Useless parentheses. | 65 |
| Useless parentheses. | 65 |
TrAP Core - com/ericsson/research/trap/spi/transports/AbstractListenerTransport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 51 |
| Useless parentheses. | 51 |
| Useless parentheses. | 51 |
TrAP Core - com/ericsson/research/trap/spi/transports/AbstractTransport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 155 |
| Useless parentheses. | 155 |
| Useless parentheses. | 385 |
| Useless parentheses. | 385 |
| Useless parentheses. | 398 |
| Useless parentheses. | 398 |
| Useless parentheses. | 398 |
| Useless parentheses. | 468 |
| Useless parentheses. | 468 |
| Useless parentheses. | 484 |
| Useless parentheses. | 484 |
| Useless parentheses. | 484 |
| Useless parentheses. | 545 |
| Useless parentheses. | 545 |
| Useless parentheses. | 595 |
| Avoid empty catch blocks | 610–612 |
| Avoid empty if statements | 845–847 |
| Useless parentheses. | 914 |
| Useless parentheses. | 914 |
| Avoid empty if statements | 968–970 |
| Avoid empty if statements | 986–988 |
| Avoid empty if statements | 1004–1006 |
| Avoid empty if statements | 1047–1049 |
| Avoid empty if statements | 1113–1117 |
| Useless parentheses. | 1226 |
| Useless parentheses. | 1289 |
| Useless parentheses. | 1289 |
| Useless parentheses. | 1311 |
| Useless parentheses. | 1311 |
| Do not hard code the IP address | 1381 |
| Useless parentheses. | 1522 |
| Useless parentheses. | 1522 |
| Avoid empty finally blocks | 1571–1575 |
TrAP Core - com/ericsson/research/trap/spi/transports/StaticKeepalivePredictor.java
| Violation | Line |
|---|---|
| Useless parentheses. | 148 |
| Useless parentheses. | 148 |
| Useless parentheses. | 170 |
| These nested if statements could be combined | 336–350 |
| Useless parentheses. | 341 |
| Useless parentheses. | 341 |
| Useless parentheses. | 384 |
| Useless parentheses. | 384 |
Index Maven Plugin - com/ericsson/research/trap/IndexConfigurator.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'logger'. | 73 |
Index Maven Plugin - com/ericsson/research/trap/IndexMojo.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'mavenProject'. | 95 |
| Avoid unused private fields such as 'repoSystem'. | 110 |
| Avoid unused private fields such as 'repoSession'. | 119 |
| Avoid unused private fields such as 'projectRepos'. | 128 |
| Avoid unused private fields such as 'pluginRepos'. | 137 |
trap-network-nio - com/ericsson/research/trap/nio/ServerSocket.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43–50 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 62 |
trap-network-nio - com/ericsson/research/trap/nio/Socket.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52–60 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 78 |
TrAP Networking: Sockets using NIO1 (Legacy) - com/ericsson/research/transport/ManagedServerSocketClient.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 38 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 50 |
TrAP Networking: Sockets using NIO1 (Legacy) - com/ericsson/research/transport/ManagedSocketClient.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 38 |
| Avoid modifiers which are implied by the context | 39 |
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 41 |
TrAP Networking: Sockets using NIO1 (Legacy) - com/ericsson/research/transport/NioManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 149 |
| Useless parentheses. | 149 |
| Useless parentheses. | 225 |
| Useless parentheses. | 292 |
| These nested if statements could be combined | 322–331 |
| These nested if statements could be combined | 326–330 |
| Avoid empty catch blocks | 351–353 |
| These nested if statements could be combined | 462–470 |
| Useless parentheses. | 498 |
| Useless parentheses. | 498 |
TrAP Networking: Sockets using NIO1 (Legacy) - com/ericsson/research/transport/ssl/SSLSocket.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 197–198 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/WSInterface.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/WSServer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 41 |
| Avoid modifiers which are implied by the context | 42 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSAbstractHandshake.java
| Violation | Line |
|---|---|
| Useless parentheses. | 212 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHixie75Handshake.java
| Violation | Line |
|---|---|
| Useless parentheses. | 62 |
| Useless parentheses. | 62 |
| Useless parentheses. | 99 |
| Useless parentheses. | 99 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHixie76.java
| Violation | Line |
|---|---|
| Useless parentheses. | 72 |
| Useless parentheses. | 72 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHixie76Handshake.java
| Violation | Line |
|---|---|
| Useless parentheses. | 69 |
| Useless parentheses. | 69 |
| Useless parentheses. | 148 |
| Useless parentheses. | 148 |
| Useless parentheses. | 208 |
| Useless parentheses. | 212 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHixieFrame.java
| Violation | Line |
|---|---|
| Useless parentheses. | 62 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHybi10Handshake.java
| Violation | Line |
|---|---|
| Useless parentheses. | 70 |
| Useless parentheses. | 70 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSHybiFrame.java
| Violation | Line |
|---|---|
| Useless parentheses. | 130 |
| Useless parentheses. | 135 |
| Useless parentheses. | 185 |
TrAP Networking: Websockets Base - com/ericsson/research/transport/ws/spi/WSRfc6455Handshake.java
| Violation | Line |
|---|---|
| Useless parentheses. | 70 |
| Useless parentheses. | 70 |
TrAP Networking: Websockets using Sockets - com/ericsson/research/transport/ws/spi/WSServerImpl.java
| Violation | Line |
|---|---|
| This for loop could be simplified to a while loop | 75–83 |
TrAP Networking: Websockets using Sockets - com/ericsson/research/transport/ws/spi/WSSocketEndpoint.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 96 |
Trap HTTP Client using Apache HTTP client - com/ericsson/research/trap/spi/transports/ApacheClientHttpTransport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 94 |
| Useless parentheses. | 94 |
| Avoid empty catch blocks | 129–131 |
| Overriding method merely calls super | 135–138 |
| Useless parentheses. | 147 |
| Useless parentheses. | 147 |
| Useless parentheses. | 147 |
| Useless parentheses. | 147 |
| Avoid empty while statements | 277 |
| Avoid empty catch blocks | 280–282 |
| Useless parentheses. | 317 |
| Useless parentheses. | 317 |
| Useless parentheses. | 317 |
| Useless parentheses. | 361 |
| Useless parentheses. | 361 |
| Unnecessary use of fully qualified name 'org.apache.http.entity.ByteArrayEntity' due to existing import 'org.apache.http.entity.ByteArrayEntity' | 405 |
| Avoid empty while statements | 418 |
| Avoid empty finally blocks | 433–435 |
Trap HTTP Client using Sun HTTP client - com/ericsson/research/trap/spi/transports/ClientHttpTransport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 108 |
| Useless parentheses. | 108 |
| Avoid empty catch blocks | 151–153 |
| Overriding method merely calls super | 159–162 |
| Useless parentheses. | 172 |
| Useless parentheses. | 172 |
| Useless parentheses. | 172 |
| Useless parentheses. | 172 |
| Useless parentheses. | 331 |
| Useless parentheses. | 331 |
| Useless parentheses. | 331 |
| Useless parentheses. | 412 |
| Useless parentheses. | 412 |
Trap HTTP Client using Sun HTTP client - com/ericsson/research/trap/spi/transports/ClientHttpsTransport.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 42–45 |
Trap HTTP Server using HTTPServlet interface - com/ericsson/research/trap/impl/http/HTTPHandler.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 38 |
Trap HTTP Server using HTTPServlet interface - com/ericsson/research/trap/impl/http/HTTPHoster.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 74–76 |
Trap HTTP Server using HTTPServlet interface - com/ericsson/research/trap/spi/transports/HTTPServletListener.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 109–112 |
Trap HTTP Server using HTTPServlet interface - com/ericsson/research/trap/spi/transports/HTTPServletTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 111–113 |
| Avoid empty catch blocks | 120–122 |
| Useless parentheses. | 131 |
| Useless parentheses. | 131 |
| Overriding method merely calls super | 187–190 |
| Avoid empty catch blocks | 271–273 |
| Useless parentheses. | 431 |
| Useless parentheses. | 431 |
Trap HTTP Server using Sun HTTP server - com/ericsson/research/trap/spi/transports/ListenerHttpTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 268–270 |
| Avoid empty catch blocks | 310–312 |
| Avoid empty catch blocks | 378–381 |
Trap HTTP Server using Sun HTTP server - com/ericsson/research/trap/spi/transports/ServerHttpTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 131–133 |
| Avoid empty catch blocks | 140–142 |
| Useless parentheses. | 149 |
| Useless parentheses. | 149 |
| Useless parentheses. | 221 |
| Useless parentheses. | 221 |
| Useless parentheses. | 373 |
| Useless parentheses. | 383 |
| Useless parentheses. | 383 |
| Useless parentheses. | 383 |
| Useless parentheses. | 383 |
| Useless parentheses. | 383 |
| Useless parentheses. | 439 |
| Useless parentheses. | 439 |
| Useless parentheses. | 494 |
| Useless parentheses. | 494 |
| Useless parentheses. | 509 |
| Useless parentheses. | 509 |
| Useless parentheses. | 509 |
TrAP Transport Loopback - com/ericsson/research/trap/spi/transports/AsynchronousLoopbackTransport.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 158–161 |
TrAP Transport Loopback - com/ericsson/research/trap/spi/transports/LoopbackTransport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 242 |
| Useless parentheses. | 242 |
| Overriding method merely calls super | 276–283 |
Socket Server using ER NIO - com/ericsson/research/trap/spi/transports/ServerSocketTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 182–184 |
| Avoid empty catch blocks | 192–194 |
| Useless parentheses. | 196 |
| Useless parentheses. | 196 |
| Do not hard code the IP address | 199 |
| Useless parentheses. | 223 |
| Useless parentheses. | 223 |
| Useless parentheses. | 223 |
TrAP Transport WebSocket by ER NIO - com/ericsson/research/trap/spi/transports/ServerWebSocketTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 127–129 |
| Useless parentheses. | 133 |
| Useless parentheses. | 133 |
| Do not hard code the IP address | 135 |
| Avoid empty catch blocks | 165–167 |
| Avoid empty catch blocks | 213–215 |
TrAP Transport WebSocket by ER NIO - com/ericsson/research/trap/spi/transports/WebSocketTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 304–306 |
| Useless parentheses. | 348 |
| Useless parentheses. | 348 |
| Useless parentheses. | 348 |
| Avoid empty finally blocks | 369–371 |
TrAP Transport WebSocket by Netty - com/ericsson/research/trap/spi/transports/WebServerSocketTransport.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 135–137 |
| Useless parentheses. | 141 |
| Useless parentheses. | 141 |
| Do not hard code the IP address | 143 |
| Overriding method merely calls super | 215–218 |
TrAP Transport WebSocket by Netty - com/ericsson/research/trap/spi/transports/WebSocketTransport.java
| Violation | Line |
|---|---|
| Avoid empty synchronized blocks | 164–166 |
| Overriding method merely calls super | 208–211 |
TrAP Transport WebSocket by Netty - com/ericsson/research/trap/spi/ws/netty/WebServerSocketHandler.java
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 1–207 |
| Avoid unused private methods such as 'handleHttpRequest(ChannelHandlerContext,HttpRequest)'. | 96 |
| Avoid unused private methods such as 'handleWebSocketFrame(ChannelHandlerContext,WebSocketFrame)'. | 141 |
| Useless parentheses. | 156 |
| Useless parentheses. | 184 |
TrAP Transport WebSocket for Tomcat Container - com/ericsson/research/trap/spi/tomcat/WSSocket.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 56 |
TrAP Transport WebSocket for Tomcat Container - com/ericsson/research/trap/spi/transports/TomcatWSListener.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 208–211 |
TrAP Transport WebSocket for Tomcat Container - com/ericsson/research/trap/spi/transports/TomcatWSTransport.java
| Violation | Line |
|---|---|
| Avoid empty synchronized blocks | 169–171 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/FutureImpl.java
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 38 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/JBossVFSPackageScanner.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 102–105 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/LockImpl.java
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 39 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/RunnableFuture.java
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 36 |
| Useless parentheses. | 66 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/StringUtilImpl.java
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 36 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/ThreadPoolImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 122–125 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/UUIDImpl.java
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 36 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/WeakMap.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 236–239 |
| Overriding method merely calls super | 242–245 |
TrAP Utils JDK 1.5 - com/ericsson/research/trap/utils/impl/SingleCallback.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'com.ericsson.research.trap.utils.Callback.SingleArgumentCallback' due to existing import 'com.ericsson.research.trap.utils.Callback' | 41 |
| Unnecessary use of fully qualified name 'com.ericsson.research.trap.utils.Callback.SingleArgumentCallback' due to existing import 'com.ericsson.research.trap.utils.Callback' | 97 |
TrAP Utils API - com/ericsson/research/trap/utils/Base64.java
| Violation | Line |
|---|---|
| Useless parentheses. | 81 |
| Useless parentheses. | 82 |
| Useless parentheses. | 82 |
| Useless parentheses. | 120 |
| Useless parentheses. | 155 |
| Useless parentheses. | 206 |
| Useless parentheses. | 206 |
| Useless parentheses. | 206 |
| Useless parentheses. | 206 |
| Useless parentheses. | 240 |
| Useless parentheses. | 241 |
| Useless parentheses. | 241 |
| Useless parentheses. | 241 |
| Useless parentheses. | 252 |
| Useless parentheses. | 252 |
| Useless parentheses. | 252 |
| Useless parentheses. | 252 |
| Useless parentheses. | 258 |
| Useless parentheses. | 258 |
| Useless parentheses. | 258 |
| Useless parentheses. | 258 |
TrAP Utils API - com/ericsson/research/trap/utils/ByteConverter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 98 |
| Useless parentheses. | 99 |
| Useless parentheses. | 100 |
| Useless parentheses. | 145 |
| Useless parentheses. | 146 |
| Useless parentheses. | 147 |
TrAP Utils API - com/ericsson/research/trap/utils/Callback.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53–62 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 92 |
TrAP Utils API - com/ericsson/research/trap/utils/Configuration.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 105 |
| Avoid modifiers which are implied by the context | 114 |
| Avoid modifiers which are implied by the context | 125 |
| Avoid modifiers which are implied by the context | 135 |
| Avoid modifiers which are implied by the context | 147 |
| Avoid modifiers which are implied by the context | 155 |
| Avoid modifiers which are implied by the context | 166 |
| Avoid modifiers which are implied by the context | 177 |
| Avoid modifiers which are implied by the context | 188 |
| Avoid modifiers which are implied by the context | 199 |
| Avoid modifiers which are implied by the context | 210 |
| Avoid modifiers which are implied by the context | 221 |
| Avoid modifiers which are implied by the context | 231 |
TrAP Utils API - com/ericsson/research/trap/utils/HexDump.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 152–154 |
TrAP Utils API - com/ericsson/research/trap/utils/IPUtilImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 147 |
| Useless parentheses. | 147 |
| Useless parentheses. | 153 |
| Useless parentheses. | 153 |
TrAP Utils API - com/ericsson/research/trap/utils/PackageScanner.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 105–108 |
TrAP Utils API - com/ericsson/research/trap/utils/PackageScannerFile.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 91–93 |
TrAP Utils API - com/ericsson/research/trap/utils/PackageScannerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 76 |
| Useless parentheses. | 76 |
| Useless parentheses. | 137 |
| Avoid empty catch blocks | 154–157 |
| Useless parentheses. | 184 |
| Avoid empty catch blocks | 193–198 |
| Avoid empty catch blocks | 199–202 |
TrAP Utils API - com/ericsson/research/trap/utils/SSLUtil.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 97–99 |
| Ensure you override both equals() and hashCode() | 123 |
TrAP Utils API - com/ericsson/research/trap/utils/StringUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 95 |
| Useless parentheses. | 118 |
| Useless parentheses. | 181 |
TrAP Utils API - com/ericsson/research/trap/utils/spi/ConfigurationImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 104 |
| Useless parentheses. | 104 |
| Useless parentheses. | 143 |
| Useless parentheses. | 280 |
| Useless parentheses. | 280 |
| Useless parentheses. | 356 |
| Useless parentheses. | 356 |
| Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 371 |
| Useless parentheses. | 414 |
| Useless parentheses. | 504 |